fix(memcache): normalize Redis TTL handling and return actual compareSetTTL result#62062
Draft
joshtrichards wants to merge 4 commits into
Draft
fix(memcache): normalize Redis TTL handling and return actual compareSetTTL result#62062joshtrichards wants to merge 4 commits into
joshtrichards wants to merge 4 commits into
Conversation
TTL handling was duplicated across multiple methods, while `compareSetTTL()` used slightly different behavior and always reported success when the compare matched, even though the Lua script ignored the actual EXPIRE result. This change makes the behavior more consistent and makes the return value of `compareSetTTL()` more truthful. Note: Negative TTL values are still passed through intentionally. Signed-off-by: Josh <josh.t.richards@gmail.com>
…names Assisted-by: Copilot:gpt-5.4 Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
2. developing
Signed-off-by: Josh <josh.t.richards@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OC\Memcache\RediscompareSetTTL()return the actual result of the underlying RedisEXPIREcallIMemcacheTTLinterface docs to match implementation and clarify TTL normalizationMotivation:
TTL handling was duplicated across multiple methods, while
compareSetTTL()used slightly different behavior and always reported success when the compare matched, even though the Lua script ignored the actualEXPIREresult. This change makes the behavior more consistent and makes the return value ofcompareSetTTL()more truthful. Also expands test coverage.Changes:
normalizeTtl()helper and use it for Redis TTL writescompareSetTTL()TTL handling with the other Redis cache methodscaSetTtlLua script to return the result ofEXPIREinstead of returning success unconditionally when the compare matchesNotes:
Checklist
3. to review, feature component)stable32)AI (if applicable)